GROOVY-10036

groovy · Apr 14, 2021 · 51e7349 · 51e7349
1 parent eb77114
commit 51e7349
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 5 deletions.
diff --git a/....core.tests.builder/src/org/eclipse/jdt/core/groovy/tests/search/DGMInferencingTests.java b/....core.tests.builder/src/org/eclipse/jdt/core/groovy/tests/search/DGMInferencingTests.java
@@ -171,6 +171,29 @@ public void testDGM11() {
         assertExprType(contents, "index", "java.lang.Integer");
     }
 
+    @Test
+    public void testDGM11a() {
+        //@formatter:off
+        String contents =
+            "def map = ['x'].<String,Object,String>collectEntries { [it, it.size()] }\n";
+        //@formatter:on
+        assertExprType(contents, "it", "java.lang.String");
+        assertExprType(contents, "map", "java.util.Map<java.lang.String,java.lang.Object>");
+    }
+
+    @Test // https://issues.apache.org/jira/browse/GROOVY-10036
+    public void testDGM11b() {
+        //@formatter:off
+        String contents =
+            "@groovy.transform.TypeChecked\n" +
+            "void test() {\n" +
+            "  def map = ['x'].<String,Object,String>collectEntries { [it, it.size()] }\n" +
+            "}\n";
+        //@formatter:on
+        assertExprType(contents, "it", "java.lang.String");
+        assertExprType(contents, "map", "java.util.Map<java.lang.String,java.lang.Object>");
+    }
+
     @Test
     public void testDGM12() {
         //@formatter:off
@@ -469,8 +492,7 @@ public void testDGM42() {
         assertExprType(contents, "it", "java.lang.String");
     }
 
-    @Test @Ignore("ClosureParams states 'List<String>' or 'String[]', but " +
-        "runtime allows for destructuring if number of elements fits into params")
+    @Test @Ignore("ClosureParams states 'List<String>' or 'String[]', but runtime allows for destructuring if number of elements fits into params")
     public void testDGM43() {
         //@formatter:off
         String contents =

diff --git a/...rg.codehaus.groovy25/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java b/...rg.codehaus.groovy25/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
@@ -5794,7 +5794,7 @@ protected ClassNode inferReturnTypeGenerics(
             } else {
                 argList.addExpression(arguments);
             }
-            return inferReturnTypeGenerics(receiver, dgmMethod, argList);
+            return inferReturnTypeGenerics(receiver, dgmMethod, argList, explicitTypeHints); // GRECLIPSE edit -- GROOVY-10036
         }
         if (!isUsingGenericsOrIsArrayUsingGenerics(returnType)) return returnType;
         if (getGenericsWithoutArray(returnType) == null) return returnType;

diff --git a/...rg.codehaus.groovy30/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java b/...rg.codehaus.groovy30/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
@@ -5583,7 +5583,7 @@ protected ClassNode inferReturnTypeGenerics(final ClassNode receiver, final Meth
             } else {
                 args.addExpression(arguments);
             }
-            return inferReturnTypeGenerics(receiver, dgm, args);
+            return inferReturnTypeGenerics(receiver, dgm, args, explicitTypeHints); // GRECLIPSE edit -- GROOVY-10036
         }
         Map<GenericsTypeName, GenericsType> resolvedPlaceholders = resolvePlaceHoldersFromDeclaration(receiver, getDeclaringClass(method, arguments), method, method.isStatic());
         resolvePlaceholdersFromExplicitTypeHints(method, explicitTypeHints, resolvedPlaceholders);

diff --git a/...rg.codehaus.groovy40/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java b/...rg.codehaus.groovy40/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
@@ -5547,7 +5547,7 @@ protected ClassNode inferReturnTypeGenerics(final ClassNode receiver, final Meth
             } else {
                 args.addExpression(arguments);
             }
-            return inferReturnTypeGenerics(receiver, dgm, args);
+            return inferReturnTypeGenerics(receiver, dgm, args, explicitTypeHints); // GRECLIPSE edit -- GROOVY-10036
         }
         Map<GenericsTypeName, GenericsType> resolvedPlaceholders = resolvePlaceHoldersFromDeclaration(receiver, getDeclaringClass(method, arguments), method, method.isStatic());
         resolvePlaceholdersFromExplicitTypeHints(method, explicitTypeHints, resolvedPlaceholders);