Enable references, implementations, and method param names code minings

Tied to Java > Editor > Code Minings preferences #919
groovy · Jun 30, 2019 · 02e59d2 · 02e59d2 · eric-milles · Jul 3, 2019
1 parent 4443c03
commit 02e59d2
Show file tree

Hide file tree

Showing 11 changed files with 58 additions and 629 deletions.
diff --git a/ide/Feature-org.codehaus.groovy.compilerless.feature/feature.xml b/ide/Feature-org.codehaus.groovy.compilerless.feature/feature.xml
@@ -51,6 +51,14 @@
          unpack="false"
    />
 
+   <plugin
+         id="org.codehaus.groovy.eclipse.mining"
+         download-size="0"
+         install-size="0"
+         version="0.0.0"
+         unpack="false"
+   />
+
    <plugin
          id="org.codehaus.groovy.eclipse.quickfix"
          download-size="0"

diff --git a/ide/Feature-org.codehaus.groovy.eclipse.photon/.gitignore b/ide/Feature-org.codehaus.groovy.eclipse.photon/.gitignore
diff --git a/ide/Feature-org.codehaus.groovy.eclipse.photon/.project b/ide/Feature-org.codehaus.groovy.eclipse.photon/.project
diff --git a/ide/Feature-org.codehaus.groovy.eclipse.photon/build.properties b/ide/Feature-org.codehaus.groovy.eclipse.photon/build.properties
diff --git a/ide/Feature-org.codehaus.groovy.eclipse.photon/epl-v10.html b/ide/Feature-org.codehaus.groovy.eclipse.photon/epl-v10.html
diff --git a/ide/Feature-org.codehaus.groovy.eclipse.photon/feature.properties b/ide/Feature-org.codehaus.groovy.eclipse.photon/feature.properties
diff --git a/ide/Feature-org.codehaus.groovy.eclipse.photon/feature.xml b/ide/Feature-org.codehaus.groovy.eclipse.photon/feature.xml
diff --git a/ide/Feature-org.codehaus.groovy.eclipse.photon/license.html b/ide/Feature-org.codehaus.groovy.eclipse.photon/license.html
diff --git a/ide/Feature-org.codehaus.groovy.eclipse.photon/pom.xml b/ide/Feature-org.codehaus.groovy.eclipse.photon/pom.xml
diff --git a/ide/org.codehaus.groovy.eclipse.mining/META-INF/MANIFEST.MF b/ide/org.codehaus.groovy.eclipse.mining/META-INF/MANIFEST.MF
@@ -7,7 +7,7 @@ Bundle-Version: 3.5.0.qualifier
 Export-Package: org.codehaus.groovy.eclipse.mining
 Import-Package: org.codehaus.groovy.eclipse.codeassist.completions,
  org.eclipse.swt.events
-Require-Bundle: org.eclipse.jdt.groovy.core;bundle-version="3.5.0",
+Require-Bundle: org.codehaus.groovy.eclipse.ui;bundle-version="3.5.0",
  org.eclipse.jface.text;bundle-version="3.13.0",
  org.eclipse.ui.workbench;bundle-version="3.111.0"
 Bundle-ActivationPolicy: lazy

diff --git a/ide/org.codehaus.groovy.eclipse.mining/plugin.xml b/ide/org.codehaus.groovy.eclipse.mining/plugin.xml
@@ -7,17 +7,57 @@
             id="org.codehaus.groovy.eclipse.mining.method_parameter"
             label="Method parameter metadata">
          <enabledWhen>
-            <with variable="editorInput">
+            <and>
+               <test property="org.eclipse.jdt.ui.hasPreference"
+                  value="editor_codemining_enabled" forcePluginActivation="true" />
+               <test property="org.eclipse.jdt.ui.hasPreference"
+                  value="java.codemining.parameterNames" forcePluginActivation="true"/>
+               <with variable="editor">
+                  <instanceof value="org.codehaus.groovy.eclipse.editor.GroovyEditor" />
+               </with>
+               <with variable="editorInput">
+                  <or>
+                     <adapt type="org.eclipse.core.resources.IFile">
+                        <test property="org.eclipse.core.resources.contentTypeId"
+                              value="org.eclipse.jdt.groovy.core.groovySource" />
+                     </adapt>
+                     <!--adapt type="org.eclipse.jdt.core.IClassFile">
+                        <instanceof value="org.eclipse.jdt.core.IClassFile" />
+                     </adapt-->
+                  </or>
+               </with>
+            </and>
+         </enabledWhen>
+      </codeMiningProvider>
+      <codeMiningProvider
+            class="org.eclipse.jdt.internal.ui.javaeditor.codemining.JavaElementCodeMiningProvider"
+            id="org.eclipse.jdt.ui.codemining.javaelement"
+            label="%JavaElementCodeMiningProvider.label">
+         <enabledWhen>
+            <and>
+               <test property="org.eclipse.jdt.ui.hasPreference"
+                  value="editor_codemining_enabled" forcePluginActivation="true" />
                <or>
-                  <adapt type="org.eclipse.core.resources.IFile">
-                     <test property="org.eclipse.core.resources.contentTypeId"
-                           value="org.eclipse.jdt.groovy.core.groovySource" />
-                  </adapt>
-                  <!--adapt type="org.eclipse.jdt.core.IClassFile">
-                     <instanceof value="org.eclipse.jdt.core.IClassFile" />
-                  </adapt-->
+                  <test property="org.eclipse.jdt.ui.hasPreference"
+                     value="java.codemining.references" forcePluginActivation="true" />
+                  <test property="org.eclipse.jdt.ui.hasPreference"
+                     value="java.codemining.implementations" forcePluginActivation="true" />
                </or>
-            </with>
+               <with variable="editor">
+                  <instanceof value="org.codehaus.groovy.eclipse.editor.GroovyEditor" />
+               </with>
+               <with variable="editorInput">
+                  <or>
+                     <adapt type="org.eclipse.core.resources.IFile">
+                        <test property="org.eclipse.core.resources.contentTypeId"
+                           value="org.eclipse.jdt.groovy.core.groovySource" />
+                     </adapt>
+	                 <!--adapt type="org.eclipse.jdt.core.IClassFile">
+                        <instanceof value="org.eclipse.jdt.core.IClassFile" />
+                     </adapt-->
+                  </or>
+               </with>
+            </and>
          </enabledWhen>
       </codeMiningProvider>
    </extension>