Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a warning about SecurityManager being deprecated #289

Closed
wants to merge 1 commit into from

Conversation

keeganwitt
Copy link
Member

@keeganwitt keeganwitt commented Oct 22, 2023

No description provided.

@keeganwitt keeganwitt marked this pull request as draft October 23, 2023 02:24
@keeganwitt keeganwitt force-pushed the print_warning_about_SecurityManager branch from f480905 to 5a972af Compare October 23, 2023 02:25
@keeganwitt keeganwitt force-pushed the print_warning_about_SecurityManager branch from 5a972af to 6b53394 Compare October 23, 2023 02:30
@keeganwitt keeganwitt marked this pull request as ready for review October 23, 2023 02:34
@bmarwell
Copy link
Contributor

This PR has too much noise on unrelated lines. I cannot even see the actual change.

@bmarwell
Copy link
Contributor

What about #287 ?

@keeganwitt
Copy link
Member Author

keeganwitt commented Oct 23, 2023

What about #287 ?

Oops. Thank you for the reminder. I think I might have had local commits started and didn't see you opened a PR about that same time before opening this one. That would be the better solution. We probably should move forward with that one and not this one.

@keeganwitt keeganwitt closed this Oct 23, 2023
@keeganwitt keeganwitt deleted the print_warning_about_SecurityManager branch October 23, 2023 21:11
@keeganwitt
Copy link
Member Author

Moved the unrelated changes into a separate PR: #290.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants