Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Modified without Checkout' does not take the ignore file into consideration. #219

Open
JimmyDeemo opened this issue Jul 7, 2020 · 4 comments
Labels

Comments

@JimmyDeemo
Copy link

JimmyDeemo commented Jul 7, 2020

Describe the current interface's shortcoming
In the Perforce window in Rider, there is a list of all the changlists active for my workspace including one labled 'Modified without Checkout'. The intention is that this will highlight any files that have been modified on disc without being checked out by the system. However, this doesn't appear to take the ignore file into consideration as when I have a Unity project all of the 'Library' file changes are listed. This floods that list and makes it hard to see actual file you need to know about.

Describe the solution you'd like
Ignored files should be in a separate list, or the 'Modified without Checkout' list should take these files into consideration.

Describe alternatives you've considered
I have tried searching for ignore file integration in the settings and the right click menues for the Perforce plugin.

Additional context
This shows an example of the files that appear here with a Unity project.

image

@groboclown groboclown added the bug label Jul 13, 2020
@groboclown
Copy link
Owner

Thanks for opening the ticket.

The p4ignore support isn't well tested at the moment. I'll look into improving this in regards to the change list file status.

@JimmyDeemo
Copy link
Author

Thank you. I know it's not high priority but thought it was worth a ticket in any case.

@groboclown
Copy link
Owner

For future-me purposes, the code that needs to include this is P4VFSListener.java, which has had this fat message sitting in it for a long time:

// TODO all add requests must go through the IgnoreFileSet.

groboclown added a commit that referenced this issue Jul 30, 2020
…rials, fixed some parts of #217, and added some fixes to #219.
@groboclown
Copy link
Owner

A small version of a fix for this is going out with v0.11.0, but it doesn't fix the "should be ignored in the VCS panel" view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants