Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit VCS Directory Settings Shares Objects #211

Closed
groboclown opened this issue Feb 28, 2020 · 1 comment
Closed

Edit VCS Directory Settings Shares Objects #211

groboclown opened this issue Feb 28, 2020 · 1 comment
Assignees
@groboclown
Labels
bug

Comments

@groboclown
Copy link
Owner

groboclown commented Feb 28, 2020 •
edited
Loading

When editing the VCS directory settings, the configuration is cloned between values. It looks like this is a shared object issue. It's particularly noticeable with the P4CONFIG setting, where the user entered data is changed across multiple other directory objects.

It looks like the dialog, when shown, need to flush the existing contents and replace them with new configuration values. It could also be that the generated objects that are passed to the configuration need to be copied.
@groboclown groboclown self-assigned this Feb 28, 2020
@groboclown
Copy link
Owner Author

There's an underlying IDE bug that causes this problem. The current code makes a best effort to perform the correct action with the information given to it, but that's limited.

@groboclown groboclown removed the Fixing label Mar 2, 2020
groboclown added a commit that referenced this issue Mar 2, 2020
@groboclown
Partial fixes to #211, NPE fixes, and normalized path view.
835b505 
Bug #211 can only be partially fixed, due to a problem with the IDE (see the bug report for details).

There were some additional NPEs discovered that came with the refactoring of the configuration passing, and with infrequently encoutnered logging.

The connection view pane now has the root paths shown with the right path separator character on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@groboclown groboclown

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@groboclown