fix: add support for Azure OpenAI Services endpoints #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfitz
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Thanks for adding this @senk! It feels a little icky to sprinkle the API key into multiple headers unconditionally. I can imagine theoretical scenarios in which it isn't great. But in practice for something as swiftly changing as AI-related endpoints this seems right, and preferable to adding some extra configuration option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
adds support for Azure OpenAI Services endpoints.
Proposed solution
add another header
api-keythat is required for azure openai services endpoints.OpenAI ignores the
api-keyheader and Microsofts token auth ignores the Authorization header so this is a pragmatic solutionto just set both to same value.Bonus: support for EntraID auth also is working (which uses the Authorization Header)
Related issues
fix #1282
Has this been tested?