basic form fields now work with civic forms architecture #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all-base-field--nccn-guideline-field-tag
…eld--nccn-guideline-field-tag entity-tag supports icon-less entities (e.g. nccn-guideline)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic fields provided by ngx-formly cannot be easily extended to work with civic's forms architecture that supports expanded field status & behavior. This PR adds base fields (input, checkbox, radio, textarea) that integrate into the forms architecture via the base-field mixin. The only observable change this will have on the UI is that in revise forms, these base fields statuses will be 'valid' for pre-populated model values, displaying the green styles. Previously they would have maintained blue 'untouched' styles.
The updated fields add a 'base-' prefix to type names, so a simple input field with the forms integration can be specified with 'base-input'.
The ngx-formly baseline fields are still available for use in simple forms that do not require interaction with civic form states using the same type names as before, e.g. 'input', 'textarea' etc.
Labelling this a 'bugfix' because in revise forms, valid prepopulated fields should display with 'valid' state styles, not 'untouched' state styles.