Support Custom Reports and Utilities In Admin #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoffman
added
the
new-feature
acoffman
force-pushed
the
admin-reports
branch
2 times, most recently
from
ec6a0bd to
d3a0e17
Compare
susannasiebert
requested changes
Apr 19, 2024
server/app/reports/clingen_counts.rb
Outdated
| @@ -0,0 +1,58 @@ | |||
| class ClingenCounts < Report | |||
| attr_reader :start_date, :end_date, :all_org_ids | |||
| CLINGEN_ORG_ID = 2 | |||
There was a problem hiding this comment.
I think it wouldn't hurt to make this generic and allow a user to pass in any org ID but with the CLINGEN_ORG_ID possibly being the default for now. We don't necessarily need to expose this option yet, but I'm just looking forward to when we will have an editor console available in the main UI and might want to allow a user to generate this report for any of their own organizations.
There was a problem hiding this comment.
Yeah, agreed. That's really easy to do actually. I can make that change.
Co-authored-by: Susanna Kiwala <susanna.kiwala@wustl.edu>
acoffman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.