-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add side for one bus shortCircuit result #2282
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
: side === BranchSide.TWO | ||
? intl.formatMessage({ id: 'Side2' }) | ||
: undefined; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this function can be outside the component:
function convertSide(side?: string) {
switch (side) {
case BranchSide.ONE:
return'Side1';
case BranchSide.TWO:
return 'Side2'
default:
return undefined;
}
}; or as const const sideMap = {
[BranchSide.ONE]: 'Side1',
[BranchSide.TWO]:'Side2',
}; andthen
side: intl.formatMessage({ id: convertSide(side) })
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to duplicate it I noticed that it's used by LF and SA also I just imported it
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
Quality Gate passedIssues Measures |
No description provided.