Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve filter ihm #573

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

improve filter ihm #573

wants to merge 21 commits into from

Conversation

Mathieu-Deharbe
Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe commented Sep 11, 2024

The point is fore the filter ceration/update ihm to have :

  • a fixed height (almost full height screen (95% actually))
  • an unscrollable header (but with a scrollable lower part)

Main problems :

  • the system used here made of Boxes 100% height doesn't work well with the Grid heavy current system => is there a way to get the same result with grids ?
  • styles should be centralised instead of being copy pasted (including those from full screen contingency ihm gridexplore-app#530)

To be tested :
use of grids with a column alignment. Cf Tristan example :

<Grid
  container
  direction="column"
  sx={{
    justifyContent: "flex-start",
    alignItems: "stretch",
  }}
><Grid container item xs="auto"><Item>adapt to content</Item></Grid><Grid container item xs><Item>get the rest of space</Item></Grid></Grid>

Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 237 files.

Valid Invalid Ignored Fixed
219 1 17 0
Click to see the invalid file list
  • src/components/filter/HeaderFilterForm.tsx

src/components/filter/HeaderFilterForm.tsx Show resolved Hide resolved
Mathieu-Deharbe and others added 6 commits September 18, 2024 16:06
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe Mathieu-Deharbe changed the title draft refacto improve filter ihm improve filter ihm Sep 26, 2024
Mathieu-Deharbe and others added 11 commits September 26, 2024 15:15
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
Copy link

sonarcloud bot commented Oct 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant