Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checkbox list to make is easier to customize #566

Merged
merged 9 commits into from
Sep 18, 2024

Conversation

klesaulnier
Copy link
Contributor

No description provided.

LE SAULNIER Kevin added 3 commits August 30, 2024 11:10
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier@rte-france.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier@rte-france.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier@rte-france.com>
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK
Test OK

@@ -648,6 +646,21 @@ function AppContent({ language, onLanguageClick }) {
setCheckBoxListOption(res);
}
}}
onItemClick={(item) => console.log('clicked', item)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's for the demo, to make a working example of onItemClick

Copy link

sonarcloud bot commented Sep 18, 2024

@klesaulnier klesaulnier merged commit d6ab27b into main Sep 18, 2024
4 checks passed
@klesaulnier klesaulnier deleted the improve_checkbox_list branch September 18, 2024 07:50
capyq pushed a commit that referenced this pull request Sep 30, 2024
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants