fix jest transpiling all node modules, make tests fast again #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previous regexp is bugged, it requires '//' in the filename !! As a result, all the files in node_modules don't pass the regex so nothing is ignored => everything is transformed jest caches this in /tmp/jest_* so rerunning tests is fast, but the first time jest takes minutes to transform everything also the previous regex was incomplete (missing other files that need transforming) but this was not visible because it transformed everything anayway use the same regex as gridstudy gridexplore for consistency...
jonenst
force-pushed
the
fixjesttransformallnodemodules
branch
from
330e7b2
to
f07d86c
Compare
sBouzols
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous regexp is bugged, it requires '//' in the filename !! As a result, all the files in node_modules don't pass the regex so nothing is ignored => everything is transformed
jest caches this in /tmp/jest_* so rerunning tests is fast, but the first time jest takes minutes to transform everything
also the previous regex was incomplete (missing other files that need transforming) but this was not visible because it transformed everything anayway