Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better fix: nested grid size issue #2473

Merged
merged 1 commit into from
Sep 27, 2023
Merged

better fix: nested grid size issue #2473

merged 1 commit into from
Sep 27, 2023

Conversation

adumesny
Copy link
Member

Description

  • fix Widget width reported incorrectly by save() after dragging from wider nested grid #2394]
  • better fix that makes sure we keep wanted size when an item is dropped on us (so we remember in case we change grid column)
  • also changed to not save x,y during dropping since the drag behavior will figure where to put it, and that means we don't cache that layout that might not apply to the new grid anyway.
  • added a running example showing issue.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
better fix: nested grid size issue
aaf4773 
* fix gridstack#2394]
* better fix that makes sure we keep wanted size when an item is dropped on us (so we remember in case we change grid column)
* also changed to not save x,y during dropping since the drag behavior will figure where to put it, and that means we don't cache that layout that might not apply to the new grid anyway.
* added a running example showing issue.
@adumesny adumesny merged commit 820c0cf into gridstack:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Widget width reported incorrectly by save() after dragging from wider nested grid
1 participant
@adumesny