added constant space and test #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
==========================================
- Coverage 88.46% 88.29% -0.18%
==========================================
Files 163 164 +1
Lines 19041 19079 +38
==========================================
+ Hits 16845 16846 +1
- Misses 2196 2233 +37
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
ConstantFESpace, which represents constants defined on the whole domain.This type allows us, e.g., to impose the mean value of the pressure via an additional equation/unknown (i.e., a Lagrange multiplier).
In order to test it, by now, we have just applied the imposition of the mean value of the FE solution to that of the analytical solution of a Poisson problem with Dirichlet boundary conditions on the whole domain. As expected, in this particular case, the constraint does not have any affect on the FE solution, its just imposing something which is already fulfilled by the solution.