Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Towards AD for Skeleton integration terms - gradient added #797

Merged
merged 13 commits into from
Jun 13, 2022
Merged

Towards AD for Skeleton integration terms - gradient added #797

merged 13 commits into from
Jun 13, 2022

Commits on Jun 10, 2022

  1. Towards AD for Skeleton integration terms - gradient added 

    * Added functionality for performing gradient of functionals involving integrals over Skeleton faces
* corresponding tests for the new constructs and functionalities have also been added
    @kishore-nori
    kishore-nori committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    26795f3 View commit details
    Browse the repository at this point in the history

  2. changed Gridap.gradient to gradient to fix error

    @kishore-nori
    kishore-nori committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    959ef6e View commit details
    Browse the repository at this point in the history

  3. Added addl. comments regarding the feature and linked to PR

    @kishore-nori
    kishore-nori committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    c23cc84 View commit details
    Browse the repository at this point in the history

  4. Added additional descr. comments for SkeletonCellFieldPair

    @kishore-nori
    kishore-nori committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    da76ec3 View commit details
    Browse the repository at this point in the history

  5. Added comments on the change_domain fix and the arbitrary choice of p… 

    …lus side
    @kishore-nori
    kishore-nori committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    a15f357 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. small corrections in NEWS.md

    @kishore-nori
    kishore-nori committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    e48edcf View commit details
    Browse the repository at this point in the history

  2. moved the outer SkeletonCellFieldPair constructor as an inner one

    @kishore-nori
    kishore-nori committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    3b73899 View commit details
    Browse the repository at this point in the history

  3. changed a.trian to getfield(a,:trian) for SkeletonCellFieldPair [skip… 

    … ci]
    @kishore-nori
    kishore-nori committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    85b035a View commit details
    Browse the repository at this point in the history

  4. Moved autodiff_array_### family for Skeleton terms to `FEAutodiff.j… 

    …l` to resolve circular depedency arising from BlockMap usage
    @kishore-nori
    kishore-nori committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    82df0e1 View commit details
    Browse the repository at this point in the history

  5. added using ForwardDiff to Gridap.FESpaces to fix errors

    @kishore-nori
    kishore-nori committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    223a76e View commit details
    Browse the repository at this point in the history

  6. removed trian from SkeletonCellFieldPair and added back inner and out… 

    …er constructor
    @kishore-nori
    kishore-nori committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    2e52ba8 View commit details
    Browse the repository at this point in the history

  7. * Removed SkeletonCellFieldPair tests related to SkeletonTriangulation 

    * moved the tests into the inner constructor
* now the constructor for SCFP doesn't take SkeletonTriangulation as input
    @kishore-nori
    kishore-nori committed Jun 13, 2022
    2 Configuration menu
    Copy the full SHA
    5b33102 View commit details
    Browse the repository at this point in the history

  8. * Changed recursive inner-outer constructor loop of SkeletonCellField… 

    …Pair

* added back trian field to SkeletonCellFieldPair, but not via constuctors
* fixed and added SkeletonCellFieldPairTests to CellDataTests runtests.jl
    @kishore-nori
    kishore-nori committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    7ae059d View commit details
    Browse the repository at this point in the history