Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest vertex bisection in 2D [WIP] #733

Merged
merged 98 commits into from
May 31, 2022
Merged

Conversation

aerappa
Copy link
Contributor

@aerappa aerappa commented Dec 16, 2021

Addresses #709. All tests passing on my machine.

A couple of sticking points that I had:

  1. get_cell_node_ids(grid) returns a Gridap custom type Table. It seems this is not intended to be mutable. However, the algorithm I am using requires changing rows for node_ids. For now I a copying this object to a Matrix and doing operations on the matrix. However, I also have another branch where I tried to stick with the table until I got stuck on the mutability. This is probably pretty bad for the memory footprint as well.
  2. As I mentioned in the issue, I am sort of "cheating" by not recomputing the labels manually as @fverdugo suggested. Perhaps we can now discuss what he had in mind by this.
  3. I only added two files, one in /src and one in /test. I'm not sure exactly what organizational structure is desired.

writevtk possible for UnstructuredGrid but not for Triangulation
This is almost certainly due to the fact that nvb and longest edge are
equivalent for a uniform mesh
@santiagobadia santiagobadia merged commit 5dc2a29 into gridap:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants