CellFE constructor now gets optional arguments and pass them down #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
such that now one may pass an arbitrary list of optional arguments to the CellFE constructor
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
==========================================
- Coverage 88.06% 88.06% -0.01%
==========================================
Files 132 132
Lines 15040 15038 -2
==========================================
- Hits 13245 13243 -2
Misses 1795 1795
Continue to review full report at Codecov.
|
… passing_cellfe_optargs
…into passing_cellfe_optargs
fverdugo
requested changes
Dec 2, 2021
fverdugo
requested changes
Dec 2, 2021
fverdugo
requested changes
Dec 2, 2021
amartinhuertas
changed the title
fverdugo
approved these changes
Dec 3, 2021
|
@amartinhuertas for me we can merge this and release a new patch. |
Ok. I will do it. But ... let me check it first from GridapDistributed.jl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fverdugo @santiagobadia
This PR includes a set of changes I have required in order to implement my current approach for globally consistent parallel RT spaces in GridapDistributed.jl. (see gridap/GridapDistributed.jl#64 for more details). Let me know your thoughs (perhaps there are better approaches, but I think this is a resonable one, e.g., it does not introduce breaking release changes in Gridap).
To be merged after PR #726