Extended functions for ArrayBlock (II) #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fverdugo
requested changes
Jun 28, 2021
src/Fields/ArrayBlocks.jl
Outdated
| @@ -152,6 +152,18 @@ function evaluate!(cache,::typeof(unwrap_cached_array),a::ArrayBlock) | |||
| r | |||
| end | |||
|
|
|||
| Arrays.setsize!(a::ArrayBlock,s::NTuple{N,<:Integer}) where {N} = @notimplemented | |||
|
|
|||
| function Arrays.setsize!(a::ArrayBlock,b::ArrayBlock) | |||
There was a problem hiding this comment.
I am afraid that this would not work when we have nested blocks. I have to think how to implement this.
There was a problem hiding this comment.
I see, I had not thought about nested blocks...
There was a problem hiding this comment.
It seems that the tests are about to pass with the new implementation
Codecov Report
@@ Coverage Diff @@
## master #623 +/- ##
==========================================
+ Coverage 87.94% 87.97% +0.03%
==========================================
Files 134 134
Lines 14243 14264 +21
==========================================
+ Hits 12526 12549 +23
+ Misses 1717 1715 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @fverdugo,
I have extended
setsize!for ArrayBlocks and_compress!forTuple{ArrayBlock,ArrayBlock}.Bimaterial tests in
GridapEmbedded#gridap_v0.16pass, if I apply these changes.Please, review and accept the merge request, whenever you have some time. Thanks!