Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ssh secret to compathelper yml file #528

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

amartinhuertas
Copy link
Member

Tries to solve issue #527

@amartinhuertas
Copy link
Member Author

@fverdugo ... is there any way to manually trigger CompatHelper from this branch so that we can double check that this PR solves the issue? I did not come up with a solution after quick searching, perhaps we can just accept the PR and then keep in mind that we have to check this in the next CompatHelper action.

@codecov-io
Copy link

codecov-io commented Jan 27, 2021

Codecov Report

Merging #528 (4fd7f44) into master (ed3334e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   86.14%   86.16%   +0.01%     
==========================================
  Files         145      145              
  Lines       11327    11327              
==========================================
+ Hits         9758     9760       +2     
+ Misses       1569     1567       -2     
Impacted Files Coverage Δ
src/FESpaces/FESpacesWithConstantFixed.jl 74.32% <0.00%> (+2.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed3334e...4fd7f44. Read the comment docs.

@fverdugo
Copy link
Member

we can just accept the PR and then keep in mind that we have to check this in the next CompatHelper action.

Let's do this!

@fverdugo fverdugo merged commit 5d7252b into master Jan 27, 2021
@fverdugo fverdugo deleted the adding_ssh_secret_to_compathelper_yml_file branch January 27, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants