Added missing get_constant_approach() getter to FESpaceWithConstantFixed

[amartinhuertas]

No description provided.

[codecov-commenter]

Codecov Report

Merging #409 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
- Coverage   87.27%   87.26%   -0.02%     
==========================================
  Files         158      158              
  Lines       11092    11094       +2     
==========================================
  Hits         9681     9681              
- Misses       1411     1413       +2     

Impacted Files	Coverage Δ
src/FESpaces/FESpacesWithConstantFixed.jl	76.00% <100.00%> (-2.09%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e0e6a...75509ba. Read the comment docs.

[fverdugo]

@amartinhuertas

get_constant_approach should return a type or an instance? Normaly, these functons return an instance so that you can do dispatch easily

[amartinhuertas]

get_constant_approach should return a type or an instance? Normaly, these functons return an instance so that you can do dispatch easily

I guess this is a matter of convention, right?

Using instances you can dispatch as ::T instead of ::Type{T}, right?

Done!

[fverdugo]

Using instances you can dispatch as ::T instead of ::Type{T}, right?

Yes, this is the only reason. The first option is kind of nicer.

[fverdugo]

@amartinhuertas if you want to register a new version, could you please prepare the release in branch release-0.14 (you will need first pull from master git pull origin master from release-0.14) and open a PR ?

A couple of important things from https://github.com/gridap/Gridap.jl/wiki/How-to-register-a-julia-package

Make sure that the version number in the Project.toml is the one you want to register (usually version 0.1.0 for new packages).

Before releasing, make sure that the NEWS.md file contains the right date and version number and that Project.toml has the right version number.

[amartinhuertas]

could you please prepare the release in branch release-0.14 (you will need first pull from master git pull origin master from release-0.14) and open a PR ?

Sure! I will do it now.