Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up nodal reffe #321

Merged
merged 4 commits into from
Jul 14, 2020
Merged

Clean up nodal reffe #321

merged 4 commits into from
Jul 14, 2020

Conversation

fverdugo
Copy link
Member

No description provided.

@fverdugo
Copy link
Member Author

Further addresses issue #314

@codecov-commenter
Copy link

Codecov Report

Merging #321 into master will increase coverage by 0.07%.
The diff coverage is 95.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   88.42%   88.50%   +0.07%     
==========================================
  Files         152      152              
  Lines       10342    10265      -77     
==========================================
- Hits         9145     9085      -60     
+ Misses       1197     1180      -17     
Impacted Files Coverage Δ
src/Geometry/UnstructuredGrids.jl 69.29% <ø> (ø)
src/ReferenceFEs/ReferenceFEs.jl 100.00% <ø> (ø)
src/Visualization/Vtk.jl 93.00% <ø> (ø)
src/ReferenceFEs/LagrangianRefFEs.jl 94.24% <93.75%> (-1.87%) ⬇️
src/ReferenceFEs/CLagrangianRefFEs.jl 96.09% <96.09%> (ø)
src/FESpaces/CellBases.jl 87.64% <100.00%> (ø)
src/FESpaces/FESpaceFactories.jl 85.29% <100.00%> (+1.47%) ⬆️
src/FESpaces/SparseMatrixAssemblers.jl 98.01% <100.00%> (ø)
src/Geometry/Triangulations.jl 78.48% <100.00%> (-1.27%) ⬇️
src/ReferenceFEs/CDLagrangianRefFEs.jl 92.14% <100.00%> (-6.40%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d41bd...82e12f2. Read the comment docs.

@fverdugo fverdugo merged commit 1aef369 into master Jul 14, 2020
@fverdugo fverdugo deleted the clean_up_nodal_reffe branch July 14, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants