Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolate multifield #279

Merged
merged 4 commits into from
Jun 15, 2020
Merged

Interpolate multifield #279

merged 4 commits into from
Jun 15, 2020

Conversation

oriolcg
Copy link
Member

@oriolcg oriolcg commented Jun 12, 2020

No description provided.

@oriolcg oriolcg added the enhancement New feature or request label Jun 12, 2020
@oriolcg oriolcg requested a review from fverdugo June 12, 2020 07:15
@oriolcg oriolcg self-assigned this Jun 12, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #279 into master will increase coverage by 0.02%.
The diff coverage is 94.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
+ Coverage   88.26%   88.28%   +0.02%     
==========================================
  Files         153      153              
  Lines        9963    10023      +60     
==========================================
+ Hits         8794     8849      +55     
- Misses       1169     1174       +5     
Impacted Files Coverage Δ
src/FESpaces/FESpaces.jl 100.00% <ø> (ø)
src/MultiField/MultiField.jl 100.00% <ø> (ø)
src/FESpaces/CLagrangianFESpaces.jl 96.29% <50.00%> (ø)
src/FESpaces/ZeroMeanFESpaces.jl 79.59% <66.66%> (-3.02%) ⬇️
src/FESpaces/SingleFieldFESpaces.jl 85.90% <93.93%> (+0.42%) ⬆️
src/FESpaces/DirichletFESpaces.jl 75.00% <100.00%> (ø)
src/FESpaces/ExtendedFESpaces.jl 94.73% <100.00%> (ø)
src/FESpaces/FESpacesWithLastDofRemoved.jl 87.71% <100.00%> (+1.44%) ⬆️
src/FESpaces/FESpacesWithLinearConstraints.jl 95.02% <100.00%> (+0.06%) ⬆️
src/FESpaces/TrialFESpaces.jl 93.33% <100.00%> (-1.91%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5905d...3b641e3. Read the comment docs.

Copy link
Member

@fverdugo fverdugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oriolcg Nice work!

I have added some minor comments.

Can you also add few lines in NEWS.md about the changes/additions?

In the "Added" section, say something like interpolation is now supported also for multifield spaces. In the "Changed" section, say something in the direction that the SingleFieldFESpace interface has changed. A new function gather_free_and_dirichlet_values! is added as mandatory and the old one gather_free_and_dirichlet_values is now optional.

Thanks!

src/FESpaces/FESpacesWithLastDofRemoved.jl Outdated Show resolved Hide resolved
src/FESpaces/FESpacesWithLinearConstraints.jl Outdated Show resolved Hide resolved
src/FESpaces/SingleFieldFESpaces.jl Show resolved Hide resolved
src/FESpaces/SingleFieldFESpaces.jl Outdated Show resolved Hide resolved
src/FESpaces/TrialFESpaces.jl Show resolved Hide resolved
src/FESpaces/TrialFESpaces.jl Show resolved Hide resolved
src/FESpaces/TrialFESpaces.jl Show resolved Hide resolved
src/FESpaces/ZeroMeanFESpaces.jl Show resolved Hide resolved
src/FESpaces/ZeroMeanFESpaces.jl Show resolved Hide resolved
src/FESpaces/ZeroMeanFESpaces.jl Show resolved Hide resolved
@oriolcg
Copy link
Member Author

oriolcg commented Jun 12, 2020

Requested modifications added in the recent commit.

@fverdugo fverdugo merged commit 9117625 into master Jun 15, 2020
@fverdugo fverdugo deleted the interpolate_multifield branch June 15, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants