Refactor/tensor values #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs to clean and reorder the code
Comment MonomialBasisTests as 3D TensorValues are being used. Currently not considered.
…rstand why is needed).
Some operations pending and its corresponding tests
…sorValue. #210 Pending: Some operations and tests (ongoing)
…actor/TensorValues
Adapt TensorValues tests to latests modifications.
|
note comment at line 192 in
|
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 88.91% 88.12% -0.80%
==========================================
Files 146 150 +4
Lines 9029 9185 +156
==========================================
+ Hits 8028 8094 +66
- Misses 1001 1091 +90
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 88.98% 88.19% -0.80%
==========================================
Files 148 153 +5
Lines 9684 9958 +274
==========================================
+ Hits 8617 8782 +165
- Misses 1067 1176 +109
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to solve #210