Improve performance of PR 967 #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tface_to_mface_map of BodyFittedTriangulation is moved to the BodyFittedTriangulation constructor, so that it is performed only once and not each time we call get_glue. Added a trait to BodyFittedTriangulation that stores the result of the test on injectivity. Besides, for correctness, the mface_to_tface_map is set to nothing as currently PosNegPartition is not prepared to handle non-injective mappings. This will have to be replaced by a proper data structure that is able to handle non-injective mappings if in the future we find an scenario in which this inverse mapping is required to be used.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1026 +/- ##
==========================================
+ Coverage 88.22% 88.23% +0.01%
==========================================
Files 179 179
Lines 22580 22593 +13
==========================================
+ Hits 19922 19936 +14
+ Misses 2658 2657 -1 ☔ View full report in Codecov by Sentry. |
SkeletonTriangulation
…gridap/Gridap.jl into facet_integration_non_conforming_meshes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance optimization. The test on the injectivity of the tface_to_mface_map of BodyFittedTriangulation is moved to the BodyFittedTriangulation constructor, so that it is performed only once and not each time we call get_glue. Added a trait to BodyFittedTriangulation that stores the result of the test on injectivity.
Besides, for correctness, the mface_to_tface_map is set to nothing as currently PosNegPartition is not prepared to handle non-injective mappings. This will have to be replaced by a proper data structure that is able to handle non-injective mappings if in the future we find an scenario in which this inverse mapping is required to be used.