Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display toast message if user quickly sends transaction on different networks #15

Closed
wants to merge 1 commit into from

Conversation

vkameswaran
Copy link

Show toast if user submits confirmation on different networks within a minute.

Copy link

@greptile-apps-local greptile-apps-local bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request introduces a new feature to display a toast message when a user quickly sends transactions on different networks within a minute. Here's a summary of the key changes:

  • Added new localization string for the network switch message in the English locale file.
  • Implemented new methods in AppStateController to handle last interacted confirmation info.
  • Created new components for the network change toast, including styling and tests.
  • Integrated the NetworkChangeToastLegacy component into various confirmation-related components.
  • Added support for storing and managing network switch details in the app state.
  • Updated the Confirm page to include the new NetworkChangeToast component.
  • Introduced a new type LastInteractedConfirmationInfo to track confirmation interactions.
  • Added new actions in the store to handle network switching and related functionality.

These changes aim to improve user experience by providing clear feedback when transactions are submitted on different networks in quick succession, potentially preventing errors or confusion.

17 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants