Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workflow to apply needs-qa label on creation of PRs to master #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lizard-boy
Copy link

@lizard-boy lizard-boy commented Oct 19, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

For PRs against master, we want to enforce a needs-qa label. We currently have an enforce-labels action that will prevent merging if the needs-qa label exists. Currently we rely on the engineer to remember to add it when they create the PR. This action will run on PR creation and automatically add the label.

The equivalent action is already in place on the clients repo.

Code changes

  • label-issue-pull-request.yml: New workflow to apply the needs-qa label.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Greptile Summary

This PR introduces a new GitHub Actions workflow to automatically apply the 'needs-qa' label to pull requests targeting the master branch, complementing the existing enforce-labels workflow.

  • Added .github/workflows/label-issue-pull-request.yml to automatically label PRs targeting master
  • Workflow triggers on PR creation, excluding changes to workflow files
  • Uses andymckay/labeler action to apply 'needs-qa' label for non-fork PRs
  • Complements existing enforce-labels.yml workflow, which prevents merging PRs with 'needs-qa' label
  • Automates a manual step, reducing the risk of engineers forgetting to add the label

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants