Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix tests for Elixir/OTP versions and small refactors. #48

Merged
merged 5 commits into from
Dec 2, 2020
Merged

Matrix tests for Elixir/OTP versions and small refactors. #48

merged 5 commits into from
Dec 2, 2020

Conversation

jechol
Copy link
Contributor

@jechol jechol commented Oct 20, 2020

  • Add matrix tests for Elixir/OTP versions for Elixir >= 1.6.
  • Remove deprecated Supervisor.Spec.worker usage.
  • Remove init/1 from generated docs.

@jechol
Copy link
Contributor Author

jechol commented Oct 21, 2020

Matrix tests was already useful this PR itself.
Only 1 combination failed at https://github.com/grempe/ex_rated/actions/runs/317756047

grempe
grempe approved these changes Dec 2, 2020
View reviewed changes
Copy link
Owner

@grempe grempe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grempe grempe merged commit 98db425 into grempe:master Dec 2, 2020
@grempe
Copy link
Owner

grempe commented Dec 2, 2020

Thanks for the pull request!

@grempe
Copy link
Owner

grempe commented Dec 2, 2020

Version 2.0.1 with this PR included has been published. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grempe grempe grempe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jechol @grempe