Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate glyph for sharp accidental (alteration sign) #1399

Closed
maxpawkas opened this issue Feb 6, 2018 · 33 comments
Closed

Alternate glyph for sharp accidental (alteration sign) #1399

maxpawkas opened this issue Feb 6, 2018 · 33 comments

Comments

@maxpawkas
Copy link

Gregorio uses it's own glyph for a sharp accidental.

Graduale Novum - a recognized (and trendsetting) chant book using neography (sharps included) uses a more "standard" form for a sharp.

Would you consider adding an .alt glyph for the sharp to follow this trend?

gngregorio

@henryso
Copy link
Contributor

henryso commented Feb 11, 2018

I think this is a good idea, but I'm not the best person when it comes to drawing glyphs. Truly, the largest difficulty here is in drawing the glyph.

@rpspringuel
Copy link
Contributor

The first step is to choose the style for the sharp glyph, as there are several. The one in the image @maxpawkas posted has the same thickness lines for both the vertical and the horizontal, but I seen sharps that use a thicker line for the horizontal (see this picture). There's also the question of the angles. @maxpawkas image angles the verticals while others will angle the horizontals (in the aforelinked picture and the unicode character: ♯).

What sort of look should we be going for if we include this glyph?

@maxpawkas
Copy link
Author

I think it’s better to follow a trend somebody has already started rather
than creating a new one (there is a Gregorio-specific sharp already).

Graduale Novum is a brand recognized widely in the Gregorian word, so I
don’t see any better options to follow when it comes to adding a sharp
glyph to Gregorio. Sharp in Gregorian Repertoire is something they (GN)
really introduced.

@rpspringuel
Copy link
Contributor

Looking at that glyph again, I think what GN used was the pound sign (or hashtag for you new fangled social media users): # At least on my system, it has the same slants as shown in the image.

Makes me wonder if the GN people know the difference between # and ♯.

If we follow the GN convention, then I would guess that at some point someone will complain that the sign isn't "correct" from a musical perspective. @henryso, how hard would it be to add two alternate sharp glyphs?

@maxpawkas can you extract a high resolution scan of the GN sharp without anything else in the image? If you want that specific glyph, having such a scan would make drawing it easier (as it could serve as a tracing template in FontForge).

@maxpawkas
Copy link
Author

@rpspringuel I certainly can do my best to extract the scan. Not today tho.

I’m pretty sure the glyph they used has been chosen on purpose. The GN people are well educated musicians with academic degrees. They’re working on musical restitution of Gregorian Chant.

The decision to use a pound sign rather than the more common sharp glyph to me seems to be an esthetic decision. On a “normal” music staff the sharp is bigger than the field between lines. Here though the sharp is entirely between lines. Their choice won’t allow the horizontal lines of the sharp cross the lines of the staff neither when placed on a line nor when between.
Notice how the sharp would “touch” the line in the example at the top had the horizontals been angled instead of verticals.

GN is a publication that (up to my knowledge) has first introduced sharps to GREG and hence - it’s always going to be a reference for any following editions.

@henryso
Copy link
Contributor

henryso commented Feb 11, 2018

@rpspringuel It's not hard to add glyphs once they're drawn, but they take up space, and these things take up two slots each. In my opinion (and again, I'm not really an authority on aesthetics), the GN sharp doesn't harmonize with the rest of the glyphs. The verticals on both the flat and the natural that we currently have in the font have their verticals perpendicular to the staff lines. If it were me, I think that something fully square (like a tic-tac-toe board) might be best. I'm curious about the source of the current "X" shaped sharp glyph. It's been that way as far back as I've been involved with gregorio as a user.

@rpspringuel
Copy link
Contributor

The GN people are well educated musicians with academic degrees.

Certainly, but we're talking about a typographical issue here, not a musical one. Knowing the difference between the two glyphs involves being familiar with either the Unicode spec or music engraving practices. I've seen plenty of musicians who look at # on their keyboard and think its the sharp symbol.

Still, you're other points are well made and could very well represent their thinking.

they take up space, and these things take up two slots each

How are we doing on number of available code points?

I'm curious about the source of the current "X" shaped sharp glyph. It's been that way as far back as I've been involved with gregorio as a user.

Same here. @eroux, you probably designed that glyph. Where did it come from?

@henryso
Copy link
Contributor

henryso commented Feb 12, 2018

@rpspringuel We have 655 code points left.

@henryso
Copy link
Contributor

henryso commented Feb 12, 2018

Something interesting: The SMuFL (at https://w3c.github.io/smufl/gitbook/tables/medieval-and-renaissance-accidentals.html) calls the "double X" a "croix," and it's in Unicode 10.0 at U+1D1CF. SMuFL names the glyph "medRenSharpCroix."

In https://music.stackexchange.com/questions/46391/where-did-the-symbols-and-%E2%99%AF-originate-from-and-why-those, the answer from alephzero states:

The original sign for "sharp" was written using diagonal lines, like an x with double strokes. I don't know when or why the "single sharp" became more vertical, and the modern diagonal "double sharp" was first used.

I would guess that this symbol came from the same place where those Mensural and Hufnagel clefs came from.

@rpspringuel
Copy link
Contributor

Hmm... @henryso That make me think that the primary (non-hole) glyph for the sharp (both the cross one and the modern one) could be placed at their appropriate unicode code points, instead of in our private use area. That would save us some code points in the private area and by converting all the existing alterations to do that we might end up gaining a few code points even as we add a glyph (or two). How hard would it be to move the existing alterations to their appropriate code points?

@henryso
Copy link
Contributor

henryso commented Feb 12, 2018

We could use the code points for sharp, natural, and flat, but then we would need to adhere to the Unicode glyph naming. I don't think this is worth the trouble for three code points. As for the croix, that Unicode code point is not in the BMP which we are trying to stay within since using the extended Unicode planes slowed things down significantly.

@maxpawkas
Copy link
Author

maxpawkas commented Feb 13, 2018

1 2

@rpspringuel Is this any close to what you expected?

I'm attaching a zip archive with the two files in high res (1200dpi) as well.
Let me know if this will do.

GNSharp.zip

@rpspringuel
Copy link
Contributor

The first one is good. I'll see if I can't find some time to start playing with it in FontForge. It may be a while though (lots on my plate at the moment) so if anyone else wants to take up the task of adding the glyph to one of the fonts, feel free.

@henryso
Copy link
Contributor

henryso commented Feb 13, 2018

I can do it. Are we settling on that form?

@henryso
Copy link
Contributor

henryso commented Feb 13, 2018

Do we have to worry about copyright of that glyph?

@rpspringuel
Copy link
Contributor

rpspringuel commented Feb 14, 2018 via email

@henryso
Copy link
Contributor

henryso commented Feb 14, 2018

The copyright notice on the book is:

Ⓒ 2011 ConBrio Verlagsgelsellschaft, Regensburg

In Kooperation mit der Libreria Editrice Vaticana
Herstellung: ConBrio Verlagsgesellschaft, Regensburg
Druck: Friedrich Pustet KG, Regensburg

ISBN 978-3-940768-15-5
CB 1215

Reading the English Preface, there's nothing there that specifically mentions the glyphs used for engraving. In these cases, I typically assume "all rights reserved," so would consider the shapes copyrighted. To wit Solesmes, who are very protective of their engraving shapes. I don't know that we should take the risk here.

However, in the Preface, flat is indicated using an italicized b rather than a ♭ and sharp as a # rather than a ♯. So I don't think we need to take their word for the musical shape here.

Which brings me to my original statement. The real difficulty is in drawing the glyph. Not necessarily drawing it in fontforge, but rather drawing it so that it can be put into fontforge. One option is to extrapolate the Caeciliae ♯ into a ♮ by extending the lines. At least then it might harmonize with the rest of the font.

@rpspringuel
Copy link
Contributor

Good catch on the copyright issues, I wouldn't have thought of it.

However, in the Preface, flat is indicated using an italicized b rather than a ♭ and sharp as a # rather than a ♯. So I don't think we need to take their word for the musical shape here.

That makes me think that my first suspicion about the typography was correct. I'm therefore inclined to base our shape on something that more closely resembles ♯ instead of #. We can play with the size of the glyph to keep it within the lines (or at least not extending beyond them by more than the existing flat does).

I think that turning ♮ into ♯ is decent idea. If we can merge the glyph with a vertical mirror of itself, then our verticals would be taken care of and we would only need to manually work on the horizontals. It would be also be possible to simply reuse the hole glyph (though I don't know how easy the existing mapping logic would work for actually reusing the code point).

We could also borrow the ♯ from a font which permits that (e.g. Linux Libertine), though we might have issues with scaling and harmonization and would have to create a new hole glyph.

Which would be easier: borrowing a whole glyph, rescaling it (if necessary), and creating a new hole, or copying and modifying one of our existing glyphs?

@henryso
Copy link
Contributor

henryso commented Feb 14, 2018

Creating the hole is not an issue. Taking a glyph from elsewhere poses a problem with the weights of the lines not matching those of our font. I'll see what I can come up with.

@henryso
Copy link
Contributor

henryso commented Feb 15, 2018

Ok, this is what I came up with. It looks funny to me (knowing modern music) with no line behind the hole.

image

@henryso
Copy link
Contributor

henryso commented Feb 15, 2018

Here's an example with other alterations for contrast

image

@rpspringuel
Copy link
Contributor

rpspringuel commented Feb 15, 2018 via email

@henryso
Copy link
Contributor

henryso commented Feb 15, 2018

Right now, the option (\gresetlinesbehindalteration) is to hide or show for all alterations.

@henryso
Copy link
Contributor

henryso commented Feb 15, 2018

I guess it looks no funnier than hiding the lines behind flats and naturals:

image

henryso added a commit to henryso/gregorio that referenced this issue Feb 15, 2018
henryso added a commit to henryso/gregorio-test that referenced this issue Feb 15, 2018
@rpspringuel
Copy link
Contributor

Right now, the option (\gresetlinesbehindalteration) is to hide or show for all alterations.

I know that, I was wondering if it would be possible to change that. I was away from my computer without access to the code at the time. Now that I'm back home, looking at the code it would be possible, it's just a matter of expanding this \ifgre@hidealtlines check to also check which alteration is being set (value of #3) and differentiating the behavior accordingly.

Does the GN generally show lines behind the flat? If it does, then I feel that keeping things as is should be fine. If it hides that line, then I think it might be useful to create that expanded option.

@termiciasty
Copy link

Does the GN generally show lines behind the flat? If it does, then I feel that keeping things as is should be fine. If it hides that line, then I think it might be useful to create that expanded option.

The example that @maxpawkas put in the very first post shows that the lines are visible behind the sharp sign.

Are you planning on writing a GregorioTeX command for switching between sharp glyphs or is there going to be another gabc command (e.g. g#0) for the new one?

@rpspringuel
Copy link
Contributor

The example that @maxpawkas put in the very first post shows that the lines are visible behind the sharp sign.

I realize that. The issue is whether the lines show behind the flat too. As it stands we can toggle between showing the lines or not, but only at the global level, i.e., for all alterations in a score. The question is whether we need to differentiate the behavior between the different types of alterations so that the line behind a flat is hidden while the line behind the sharp appears in the same score.

Are you planning on writing a GregorioTeX command for switching between sharp glyphs or is there going to be another gabc command (e.g. g#0) for the new one?

Neither. The existing GregorioTeX functionality for swapping out glyphs covers it. See the new test for an example of how the switch is made.

@henryso
Copy link
Contributor

henryso commented Feb 15, 2018

According to the preface, besides si♭ (which will always be in a space), there is also mi♭. I will try to look for this elusive mi♭ (which would be on a line) and give you an answer unless someone beats me to it.

@henryso
Copy link
Contributor

henryso commented Feb 15, 2018

Ok, I opened the book and idly looked at a few random pages and happened to find an instance (page 296, third staff from the top, for reference). The lines do show behind the flat.

@rpspringuel
Copy link
Contributor

si♭ (which will always be in a space)

Wouldn't a fa clef put the flat on a line?

The lines do show behind the flat.

In that case our existing global setting should be sufficient. I'll review the PR this weekend.

@henryso
Copy link
Contributor

henryso commented Feb 15, 2018

You're right. I keep thinking about above the clef for the fa clef.

@maxpawkas
Copy link
Author

@henryso the shape of yours is beautiful.
It was a great idea to reshape a natural!

Chapeau bas.

henryso added a commit to henryso/gregorio that referenced this issue Feb 17, 2018
henryso added a commit to henryso/gregorio-test that referenced this issue Feb 17, 2018
@henryso
Copy link
Contributor

henryso commented Feb 17, 2018

I make some tiny changes because I thought the balance of the sharp against the natural was wrong (the glyph seemed too tall when zoomed in). As you can see here, there's not much change, but this shape makes me a bit happier.

image

henryso added a commit to henryso/gregorio-test that referenced this issue Feb 17, 2018
henryso added a commit to henryso/gregorio that referenced this issue Feb 17, 2018
@henryso henryso closed this as completed Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants