Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tuning spacelinestext on a per-line basis #1156

Closed
eroux opened this issue Jun 23, 2016 · 4 comments
Closed

tuning spacelinestext on a per-line basis #1156

eroux opened this issue Jun 23, 2016 · 4 comments
Assignees
@henryso
Labels
enhancement TeX
Milestone
4.2

Comments

@eroux
Copy link
Contributor

eroux commented Jun 23, 2016

In some rare cases, spacelinestext (including the adjustments gregorio makes) are not optimal, and a tuning must be done by hand, but I don't think it is possible with the current state... This would be needed in case where, for instance, a very low note meets a very high letter (with an accent).

Looking at this thread I think the same should be done for the other vertical spaces such as abovelinestextraise or the different future nabc heights.

My feeling is that a macro could just store these user values in a lua table, emptied at each end of score, and these could be used in the lua second pass. From this very general point of view it seems easy so it could fit into 4.2, but if it's more complex, this could go into 5.0.
@eroux eroux added this to the 4.2 milestone Jun 23, 2016
@henryso
Copy link
Contributor

henryso commented Jun 23, 2016

Can you describe the syntax? Are you expecting texverbs here?

@eroux
Copy link
Contributor Author

eroux commented Jun 23, 2016

Oh, no, I was thinking about something like \grelocalchangedim{dim}{value}{linenum}, but maybe there are some better options...

@henryso henryso self-assigned this Jul 2, 2016
@henryso
Copy link
Contributor

henryso commented Jul 3, 2016

I'll use the command grechangenextscorelinedim{line}{dim}{value}{mod} since I think that name is more obvious.

henryso added a commit to henryso/gregorio that referenced this issue Jul 3, 2016
@henryso
Added the ability to change a dimension for a given line in a score.
d21d844 
Fixes gregorio-project#1156.
henryso added a commit to henryso/gregorio-test that referenced this issue Jul 3, 2016
@henryso
Added a test to exercise per-line dimension changes.
7ba1a72 
Tests gregorio-project/gregorio#1156.
This was referenced Jul 3, 2016
Merged
Merged
@eroux
Copy link
Contributor Author

eroux commented Jul 3, 2016

Apart from the comment on the doc, this looks wonderful, this will really help in some edge cases in which there was previously no solution at all!

@henryso henryso closed this as completed Jul 4, 2016
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Jul 4, 2016
@rpspringuel
Merge commit 'f790c50299dcbf2d919e4459de8668ce6c269b19' into doc_fix
2c5f0b4 
* commit 'f790c50299dcbf2d919e4459de8668ce6c269b19': (35 commits)
  Specifically noted which spaces may be altered by grechangenextscorelinedim.
  Added the ability to change a dimension for a given line in a score. Fixes gregorio-project#1156.
  1144: fix doc typos
  oops
  document spaces
  doc, fix small bug,
  Implemented distance check for notes around virgula and divisio minima.
  do not use alterationsadjustment on clef change, reduce it
  greciliae: fix small problem of joining line height
  doc
  fix gregorio-project#1169
  attempt to fix gregorio-project#1146
  TeX part of gregorio-project#1144
  Extended the nearness check to the first two notes of podatus, clivis, and porrectus.
  gregorio-project#1138: TeX and doc
  gregorio-project#1138: change default case
  gregorio-project#1137: fix case of podatus
  Added an argument to \GreSetInitialClef indicating whether the first note is near the clef. Part of the implementation for gregorio-project#1138.
  fix gregorio-project#1137
  Add documentation for recent Nabc vertical placement changes.
  ...
rpspringuel added a commit to rpspringuel/gregorio-test that referenced this issue Sep 24, 2016
@rpspringuel
Merge branch 'release-4.2'
3ccb375 
* release-4.2: (72 commits)
  Added a test for the suppression of \GreLastOfScore. Tests gregorio-project/gregorio#1205.
  Updated test harness to handle gregorio executable with version number. Tests gregorio-project/gregorio#1197.
  Updated tests to match the oriscus orientation at unison change. Tests gregorio-project/gregorio#1177.
  Small inconsistency
  Added a test to exercise per-line dimension changes. Tests gregorio-project/gregorio#1156.
  Accepted test results after merge.
  accept tests for fix-1144
  accept changes for #1169
  accept tests for 1146
  accept tests for #1146
  accept changes for fix-1138
  changes for fix-1137
  Accepted updated results after merging gregorio-project/gregorio#1154. Tests gregorio-project/gregorio#1153.
  Accepted updated results after merge of release-4.2 into fix-1155.
  accept changes for fix-1152
  add tests for 1155
  accept tests for fix-1155
  Accepted expectations after #1148. Tests gregorio-project/gregorio#1145.
  Added the test from gregorio-project/gregorio#1141.
  Added the test from gregorio-project/gregorio#1139.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryso henryso

Labels
enhancement TeX
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
2 participants
@eroux @henryso