Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and updated tests to cover oriscus glyph expansion #195

Merged
merged 4 commits into from
Mar 14, 2016

Conversation

henryso
Copy link
Contributor

@henryso henryso commented Mar 13, 2016

As with gregorio-project/gregorio#1030, this is based on #194 and merging this will merge that.

For gregorio-project/gregorio#898 and gregorio-project/gregorio#972.
Corresponds with gregorio-project/gregorio#1030

@eroux
Copy link
Contributor

eroux commented Mar 14, 2016

This looks good except gO1e(gO1e) in oriscus.gabc, where the oriscus is going down... is it normal?

@henryso
Copy link
Contributor Author

henryso commented Mar 14, 2016

No, that looks wrong. Thanks for noticing. I'll try to fix that some time today.

@henryso
Copy link
Contributor Author

henryso commented Mar 14, 2016

The stemmed oriscus figures in the font were inverted. This brought to mind the need to describe this change in behavior in the upgrade guide. This should now be correct.

eroux added a commit that referenced this pull request Mar 14, 2016
Added and updated tests to cover oriscus glyph expansion
@eroux eroux merged commit be1abb1 into gregorio-project:develop Mar 14, 2016
@henryso henryso deleted the fix-972 branch March 14, 2016 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants