Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where rows equal to row option would cause error #948

Merged
merged 4 commits into from
Oct 15, 2019

Conversation

gabrielliwerant
Copy link
Collaborator

@gabrielliwerant gabrielliwerant commented Sep 20, 2019

Closes #942 and #994.

@gabrielliwerant gabrielliwerant added bug v3 Denotes that this issue is required for v3 release of this library labels Sep 20, 2019
@coveralls
Copy link

coveralls commented Sep 20, 2019

Coverage Status

Coverage increased (+0.1%) to 77.507% when pulling 1986670 on bugfix/issue-942-page-out-of-bounds into b8bee52 on master.

@gabrielliwerant gabrielliwerant merged commit 94d8cd0 into master Oct 15, 2019
@gabrielliwerant gabrielliwerant deleted the bugfix/issue-942-page-out-of-bounds branch October 15, 2019 02:54
waqasajaz pushed a commit to waqasajaz/mui-datatables that referenced this pull request Oct 31, 2019
* Fix issue where rows equal to row option would cause error

* Fix issue 994 by extending current page checks

* Add test for out of bounds pages in pagination
lalong13 pushed a commit to lalong13/mui-datatables that referenced this pull request Jan 15, 2020
* Fix issue where rows equal to row option would cause error

* Fix issue 994 by extending current page checks

* Add test for out of bounds pages in pagination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug lgtm v3 Denotes that this issue is required for v3 release of this library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong page number when total count of items equils selected RowsPerPage value
2 participants