Fix #778 Enhancement/switch between examples #863
Conversation
…th router) Added router cards and started adding routes.
exported all examples components
Listed the number of examples
gabrielliwerant
added
the
needs review
|
Just took a peak at this, I think this is a really good idea. If @gabrielliwerant decides to move forward with this, I'd recommend adding a link to the repo's code sandbox (https://codesandbox.io/s/github/gregnb/mui-datatables) in the Demo section of README.md. |
|
It's on my radar for sure, just been working on a bunch of other things with the table! FYI, all the PRs marked "needs review" are on my radar, like a todo list, in case you're wondering if I've forgotten about something. |
|
And I also think we could improve the documentation by adding live demo links to each option we have an example for, it would be much easier for the users to have a look on what this option actually does visually. For example, in the description of Just a thought. |
|
@alielkhateeb Live demo links would be great, but probably make more sense in a full documentation website, like what material ui has. As the library matures we could definitely use something like that, but I think we should hold off for now. I know the repo owner attempted this a while ago, so he may have thoughts on it first. |
gabrielliwerant
added
enhancement
lgtm
needs work
and removed
needs review
|
@alielkhateeb Looks like some of the other PRs were touching the |
|
@gabrielliwerant Merged. |
* [Enhancement] working on issue gregnb#778 (Switch between examples with router) Added router cards and started adding routes. * Added all the examples to examples.js exported all examples components * Fixed some exports Listed the number of examples * Added noslash type to remove the extra slash after the # from the URL (gregnb#778)
Fix #778 [Enhancement] Switch between examples.
You can use
examples.jsto easily add more examples in the future, just add the label and the component to render.