Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filterOptions.fullWidth #1340

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Added filterOptions.fullWidth #1340

merged 2 commits into from
Jun 18, 2020

Conversation

patorjk
Copy link
Collaborator

@patorjk patorjk commented Jun 17, 2020

Closes #1334

Also updated documentation for filterOptions.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 76.432% when pulling b39b860 on filterFullWidth into 07427cd on master.

@wdh2100
Copy link
Collaborator

wdh2100 commented Jun 17, 2020

const cols = (column.filterOptions && column.filterOptions.fullWidth) === true ? 2 : 1;

Good feature. but, I see a lot of duplicated code.

@patorjk
Copy link
Collaborator Author

patorjk commented Jun 17, 2020

It could probably be optimized some, I'll leave it as is for now though. Ideally, the component render methods could be re-used for something like what's done here - #1120. That feature is pretty cool but it duplicates this file, which would just lead to headaches (I would have had to edit two files for this PR).

@patorjk patorjk changed the base branch from master to v3_1_0 June 18, 2020 02:35
@patorjk patorjk merged commit 09dcc6e into v3_1_0 Jun 18, 2020
@wdh2100 wdh2100 deleted the filterFullWidth branch November 3, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to order filters independently from the columns?
3 participants