-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for custom error handling. #22
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #22 +/- ##
===========================================
- Coverage 94.12% 94.09% -0.03%
===========================================
Files 7 8 +1
Lines 579 593 +14
Branches 9 9
===========================================
+ Hits 545 558 +13
- Misses 25 26 +1
Partials 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small things to fix, then this will be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This adopts the pattern of clj-cbor for clj-pgp. It doesn't apply the pattern everywhere, but allows users to have partial success when there is a single error in a pgp stream.
Couple notes:
Unlike clj-cbor, I decided to support a
cause
, to allow deeper exception context to be supported if the consumer wants to surface that.