Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for custom error handling. #22

Merged
merged 3 commits into from
Aug 16, 2019

Conversation

brycecovert
Copy link

This adopts the pattern of clj-cbor for clj-pgp. It doesn't apply the pattern everywhere, but allows users to have partial success when there is a single error in a pgp stream.

Couple notes:
Unlike clj-cbor, I decided to support a cause, to allow deeper exception context to be supported if the consumer wants to surface that.

@codecov-io
Copy link

codecov-io commented Aug 9, 2019

Codecov Report

Merging #22 into develop will decrease coverage by 0.03%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #22      +/-   ##
===========================================
- Coverage    94.12%   94.09%   -0.03%     
===========================================
  Files            7        8       +1     
  Lines          579      593      +14     
  Branches         9        9              
===========================================
+ Hits           545      558      +13     
- Misses          25       26       +1     
  Partials         9        9
Impacted Files Coverage Δ
src/clj_pgp/core.clj 96.09% <100%> (+0.26%) ⬆️
src/clj_pgp/error.clj 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d93c6...3194085. Read the comment docs.

src/clj_pgp/core.clj Outdated Show resolved Hide resolved
@greglook greglook self-assigned this Aug 12, 2019
Copy link
Owner

@greglook greglook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts.

src/clj_pgp/core.clj Outdated Show resolved Hide resolved
src/clj_pgp/core.clj Show resolved Hide resolved
src/clj_pgp/core.clj Outdated Show resolved Hide resolved
Copy link
Owner

@greglook greglook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things to fix, then this will be good to go.

src/clj_pgp/core.clj Outdated Show resolved Hide resolved
src/clj_pgp/core.clj Show resolved Hide resolved
test/clj_pgp/test/encryption.clj Outdated Show resolved Hide resolved
Copy link
Owner

@greglook greglook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@greglook greglook merged commit 7359c30 into greglook:develop Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants