chunkExtractor.getScriptElements returns nested array in 5.13.1

[bendvc]

🐛 Bug Report

Public API for chunkExtractor.getScriptElements is described as being an Array of React <script> Elements. As of version 5.13.1 it returns an array who's first element is also an array.

To Reproduce

Unfortunately I cannot share my private repo. But the recent change to this function was the cause of this error.

loadable-components/packages/server/src/ChunkExtractor.js

Line 300 in 8cf392d

getRequiredChunksScriptElement(extraProps) {

Previously it returned a single element, but is now returning an array that isn't getting spread in this function

loadable-components/packages/server/src/ChunkExtractor.js

Line 384 in 8cf392d

getScriptElements(extraProps = {}) {

Expected behavior

chunkExtractor.getScriptElements returns an array of react script elements.

[open-collective-bot]

Hey @bendvc 👋,
Thank you for opening an issue. We'll get back to you as soon as we can.
Please, consider supporting us on Open Collective. We give a special attention to issues opened by backers.
If you use Loadable at work, you can also ask your company to sponsor us ❤️.

[theKashey]

Yep, it could flatten scripts before returning.

[markwoodward23]

@theKashey happy to pick this up if you're busy.

[theKashey]

@markwoodward23 - that would be very good. It's like a few lines to change, but I don't have any time to work on this.

[markwoodward23]

@theKashey - tried forking and install but I keep seeing this error when running tests:

FAIL  packages/server/src/ChunkExtractor.test.js
  ● Test suite failed to run

    Cannot find module '@loadable/component' from 'sharedInternals.js'

    However, Jest was able to find:
    	'./sharedInternals.js'

Any ideas?

[theKashey]

@markwoodward23 sounds like you need lerna bootstrap or yarn build made at the top level.

[markwoodward23]

@bendvc / @theKashey #607