-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLANET-7323: Remove Lodash dependencies #1150
Conversation
/unhold 43dec825-80ba-4830-8dc9-4a129199cfe0
Test instance is ready 🚀🌑 iocaste | admin | blocks report | CircleCI | composer-local.json ⌚ 2023.11.10 16:26:37 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to update ImageBlockExtension which uses lodash.assign
? 🤔 And do we need to remove them from package.json too?
454af42
to
36c949b
Compare
/unhold 1b5668bb-5e65-4f0e-b179-eef377edd35c
@mleray Good catch :) just did all that 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Ref: https://jira.greenpeace.org/browse/PLANET-7323
This is a port of Gutenberg removal of Lodash (remove _.get, remove _.debounce, etc.)
Test