Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLANET-7323: Remove Lodash dependencies #1150

Merged
merged 1 commit into from
Nov 14, 2023
Merged

PLANET-7323: Remove Lodash dependencies #1150

merged 1 commit into from
Nov 14, 2023

Conversation

lithrel
Copy link
Contributor

@lithrel lithrel commented Nov 9, 2023 •
edited
Loading

Ref: https://jira.greenpeace.org/browse/PLANET-7323

WordPress 6.4 removes Lodash dependency and provide alternative implementations of its functions.
We are currently using Lodash for duplication of WP components and some utilities but not importing it ourselves, so the Editor crashes in 6.4.

This is a port of Gutenberg removal of Lodash (remove _.get, remove _.debounce, etc.)

Test

  • E2E tests should pass
  • Our port of the FlatTermSelector should still work as expected (Post Types selection in post edition)

@lithrel lithrel self-assigned this Nov 9, 2023
@lithrel lithrel marked this pull request as draft November 9, 2023 11:05
planet-4 added a commit to greenpeace/planet4-test-iocaste that referenced this pull request Nov 9, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1150 at 454af427
acb060a 
/unhold 43dec825-80ba-4830-8dc9-4a129199cfe0
@planet-4
Copy link
Contributor

planet-4 commented Nov 9, 2023 •
edited
Loading

Test instance is ready 🚀

🌑 iocaste | admin | blocks report | CircleCI | composer-local.json

⌚ 2023.11.10 16:26:37

@lithrel lithrel marked this pull request as ready for review November 10, 2023 11:39
mleray
mleray reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@mleray mleray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to update ImageBlockExtension which uses lodash.assign? 🤔 And do we need to remove them from package.json too?

planet-4 added a commit to greenpeace/planet4-test-iocaste that referenced this pull request Nov 10, 2023
@planet-4
greenpeace/planet4-plugin-gutenberg-blocks#1150 at 36c949b4
84466d6 
/unhold 1b5668bb-5e65-4f0e-b179-eef377edd35c
@lithrel
Copy link
Contributor Author

lithrel commented Nov 10, 2023

Do we also need to update ImageBlockExtension which uses lodash.assign? 🤔 And do we need to remove them from package.json too?

@mleray Good catch :) just did all that 👍

@lithrel lithrel requested a review from mleray November 13, 2023 16:11
mleray
mleray approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@mleray mleray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@lithrel lithrel merged commit 4c51d6b into main Nov 14, 2023
15 checks passed
@lithrel lithrel deleted the rm/lodash-dep branch November 14, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mleray mleray mleray approved these changes

@Osong-Michael Osong-Michael Awaiting requested review from Osong-Michael

Assignees

@lithrel lithrel

Labels
[Test Env] iocaste
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lithrel @planet-4 @mleray