-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLANET-7511 Migrate Articles block to Posts List block #2491
base: main
Are you sure you want to change the base?
Conversation
/unhold a8b1ce39-7c7f-4eca-a817-cd74f7680ba0
Test instance is ready 🚀🌑 mars | admin | blocks report | CircleCI | composer-local.json ⌚ 2025.02.26 11:17:48 |
f8a61a5
to
e6736b7
Compare
/unhold 6668ccc3-9386-4552-8182-7600ba07a0ca
e6736b7
to
3993207
Compare
/unhold 2dba4af6-382d-45fd-a43f-9108d1c5aee6
3993207
to
212db5a
Compare
/unhold ee3dddf2-f9f9-48be-bf9d-5c48835cd091
212db5a
to
9a092ce
Compare
/unhold 6f04344f-0299-480f-abf9-4bf93f5e3adf
9a092ce
to
6984297
Compare
/unhold 955a65df-9df0-4ecc-bff2-c763d13bf805
6984297
to
0564fe7
Compare
/unhold ca571e83-bc0d-4a2d-afcd-22998820d444
0564fe7
to
bbc115b
Compare
/unhold e95ee361-6e8a-4a1f-87fb-f39be27f6d1c
bbc115b
to
981c121
Compare
/unhold 43c65240-9a63-4742-9fe1-50ef3ac9d98f
981c121
to
b98247d
Compare
/unhold e17844f7-4afc-4f46-bd6e-aecba7ce66fe
/unhold ceb9e6cd-bde4-40fa-a05c-c9ce05aebc60
/unhold 9aab267c-e29f-4254-a8c4-d47c7752f3d0
/unhold 17294fa0-c8b9-4dad-af3c-6ec0f4fee413
4ed4756
to
8995f08
Compare
/unhold 02d86a41-d205-4394-b436-49fc756d1e84
8995f08
to
72e375d
Compare
/unhold ad7efc2a-1e3c-49da-98a9-0069ee3291a0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 tested on local, works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagarsdeshmukh, shouldn't we remove the Articles block from the codebase, too?
Yes, we should, but I’m waiting for confirmation on how to handle the 'Include Articles In Post' option if we remove the articles block. I’ve added a comment on JIRA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @sagarsdeshmukh!
We also have to migrate the Additional CSS class(es).
/unhold e5fbb85f-ee71-402b-a0a6-f78c6b6d4481
63f3705
to
7125b5e
Compare
/unhold 2f7b391f-4f6a-4609-acc8-e4180d401c6d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagarsdeshmukh, we also have to migrate the Additional CSS class(es):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very picky and completely optional: I wonder if we should create a separate class for Query blocks since this migration and migration M037 share most of the code. By moving the reusable code to a separate class, it will be easier and faster to migrate Query blocks in the future and we'll avoid the Sonar Cloud analysis to fail because of duplicated code.
Those classes we already add here, WP declares them as "Additional classes" since we added them during the block variation regsitration |
Thanks @Osong-Michael |
Update review fixes
/unhold 0ffcbf83-778c-44ca-89b1-74629cd231f8
Remove Articles block tests styles, JS and php code
/unhold ff193c34-22c0-4f84-aabb-3a4431b925cf
Ref. https://jira.greenpeace.org/browse/PLANET-7511
Summary
Articles block migration to post List block
Testing
npx wp-env run cli wp p4-run-activator
npm run db:reset
.