Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Add check for overlong lines in description block #681

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2024

What

Adds a check for lines in the description block that are longer than 100 characters.
script_name is ignored because it cannot contain line breaks.
Severity for a too long line is Warning.
Severity for not finding the start or end of the description block is Error, because the check cannot work properly then.

Why

The coding style for description blocks specifies that lines should not exceed 100 characters.

References

  • Closes: VTOPS-174

Checklist

  • Tests
  • Run against all VTs in nasl/common -> 234056 Warnings, 0 Errors found

@ghost ghost self-requested a review as a code owner March 18, 2024 11:40
Copy link

github-actions bot commented Mar 18, 2024

Conventional Commits Report

Type Number
Changed 3
Removed 1
Added 2

🚀 Conventional commits found.

@mbrinkhoff mbrinkhoff added the make release To trigger GitHub release action label Mar 21, 2024
@mbrinkhoff mbrinkhoff force-pushed the overlong_description_lines branch from d6faddf to 5fc10f0 Compare March 21, 2024 09:50
@mbrinkhoff mbrinkhoff enabled auto-merge (rebase) March 21, 2024 09:50
@mbrinkhoff mbrinkhoff merged commit 28b5b7c into main Mar 21, 2024
9 of 10 checks passed
@mbrinkhoff mbrinkhoff deleted the overlong_description_lines branch March 21, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants