Change: reuse method for splitting dependencies

troubadix/plugins/dependencies.py

@@ -31,6 +31,20 @@
 )
 
 
+def split_dependencies(value: str) -> list[str]:
+    """
+    Remove single and/or double quotes, spaces
+    and create a list by using the comma as a separator
+    additionally, check and filter for inline comments
+    """
+    dependencies = []
+    for line in value.splitlines():
+        subject = line[: line.index("#")] if "#" in line else line
+        _dependencies = re.sub(r'[\'"\s]', "", subject).split(",")
+        dependencies += [dep for dep in _dependencies if dep != ""]
+    return dependencies
+
+
 class CheckDependencies(FilePlugin):
     name = "check_dependencies"
 
@@ -60,17 +74,7 @@ def run(
 
         for match in matches:
             if match:
-                # Remove single and/or double quotes, spaces
-                # and create a list by using the comma as a separator
-                # additionally, check and filter for inline comments
-                dependencies = []
-
-                for line in match.group("value").splitlines():
-                    subject = line[: line.index("#")] if "#" in line else line
-                    _dependencies = re.sub(r'[\'"\s]', "", subject).split(",")
-                    dependencies += [dep for dep in _dependencies if dep != ""]
-
-                for dep in dependencies:
+                for dep in split_dependencies(match.group("value")):
                     if not any(
                         (root / vers / dep).exists() for vers in FEED_VERSIONS
                     ):

troubadix/standalone_plugins/dependency_graph.py

@@ -23,6 +23,7 @@
     get_script_tag_pattern,
     get_special_script_tag_pattern,
 )
+from troubadix.plugins.dependencies import split_dependencies
 from troubadix.plugins.dependency_category_order import (
     VTCategory,
 )
@@ -193,21 +194,6 @@ def determine_feed(script_relative_path: Path) -> str:
         return "community"
 
 
-def split_dependencies(value: str) -> list[str]:
-    """
-    removes blank lines, strips comments, cleans dependencies,
-    splits them by commas, and excludes empty strings.
-    """
-    return [
-        dep
-        for line in value.splitlines()
-        if line.strip()  # Ignore blank or whitespace-only lines
-        # ignore comment, clean line of unwanted chars, split by ','
-        for dep in re.sub(r'[\'"\s]', "", line.split("#", 1)[0]).split(",")
-        if dep  # Include only non-empty
-    ]
-
-
 def extract_dependencies(content: str) -> list[Dependency]:
     dependencies = []