Fix: get vts endpoint #1860
Draft
Fix: get vts endpoint #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains an extension of the retriever trait to also be able to get kb items with a pattern. This is needed in order to get a list of all open ports of a target, as they are saved within the kb. Additionally added the following NASL builtin functions: - get_host_open_port - get_port_transport When creating an socket, now the acording transport used is entered into the kb
Instead of working with enums, which causes the user to always have to match the output, now different trait implementations per type is used. After that it should be easier to maintain, easier to extend and easier to use
Unlike previously TestBuilder does not create a new storage when it is running the interpreter on `results` but is now reusing the InMemoryStorage, meaning it contains previous KB items. To counter that the results are now cached instead of recreating by running the interpreter multiple times.
`GET /vts` is too slow for bombardiers default timeout. This fixes the first byte timeout issue and can be tested via: `bombardier localhost:3000/vts` which shou just return 2xx and not crash openvasd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET /vtsis too slow for bombardiers default timeout.Depends on: #1813
SC-1219