Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Add settings for date and time format. #2283

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

a-h-abdelsalam
Copy link
Contributor

What

Added independent date and time format setting.

Why

Currently the date and time formats are set with the language setting. This allows setting the time format to 12h/24h and the date format to wdmy/wmdy independently.

References

GEA-430

Copy link

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@a-h-abdelsalam a-h-abdelsalam marked this pull request as ready for review August 21, 2024 10:05
@a-h-abdelsalam a-h-abdelsalam requested a review from a team as a code owner August 21, 2024 10:05
@mattmundell
Copy link
Contributor

This looks OK. I take it this is for the use of clients like GSA, and all times in GMP will stay as they are?

Asking because there's already a bit of a mess in GMP timezones, eg GET_RESULTS can return multiple timezones in the same response:

    <modification_time>2023-03-27T12:39:24Z</modification_time>
      <severities score="0.0">
          <date>2021-02-25T13:11:24+02:00</date>

@a-h-abdelsalam
Copy link
Contributor Author

@mattmundell yes this is only intended for use in GSA

@mattmundell mattmundell merged commit 14ab614 into main Aug 21, 2024
14 of 16 checks passed
@mattmundell mattmundell deleted the add-settings-for-date-time-format branch August 21, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants