Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smaller buffer_aggregate_xml #2278

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Smaller buffer_aggregate_xml #2278

merged 3 commits into from
Sep 5, 2024

Commits on Sep 5, 2024

  1. Remove stray semicolons

    @mattmundell @a-h-abdelsalam
    mattmundell authored and a-h-abdelsalam committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b853ed4 View commit details
    Browse the repository at this point in the history

  2. Format blocks consistently in buffer_aggregate_xml 

    This function is already very long, and the if blocks around single
statements are making it more verbose. It's also more consistent,
because some were already like this.
    @mattmundell @a-h-abdelsalam
    mattmundell authored and a-h-abdelsalam committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    4bf1407 View commit details
    Browse the repository at this point in the history

  3. Use function to buffer column_info in buffer_aggregate_xml

    @mattmundell @a-h-abdelsalam
    mattmundell authored and a-h-abdelsalam committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    40ddc0c View commit details
    Browse the repository at this point in the history