Change: Use fewer queries for GET_CREDENTIALS when possible #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the trash case of GET_TARGETS check that dependent resources like credentials exist before trying to access info about them. This speeds up the GSA trashcan, by skipping some SQL queries that would always return NULL.
Conventional Commits Report
🚀 Conventional commits found. |
mattmundell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Prevent subqueries in the credential iterator when possible.
This adds a special initialiser for the credential iterator used by
GET_CREDENTIALS. The resulting SQL returns''for certain columns, depending on other values. For example, theauth_algorithmcolumn is only needed if type is 'snmp', so when type is any other value then the SQL returns''(saving a query to tablecredentials_data). Similarly, columns likepasswordare only used when a format is requested, so they are skipped for the standard case (CREDENTIAL_FORMAT_NONE) using theleanflag.Why
Much faster.
With 1000 trash credentials:
main: 51s
pr: 3s
About half the saving is coming from fc8765d, which skips the decryption when accessing the private key for
credential_iterator_format_available.References
Waits for #2121