Addressed lintian/shellcheck warnings #1471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfi-gb
suggested changes
Mar 29, 2021
tuto193
force-pushed
the
lintian_warnings_PL-52
branch
from
cc60d37
to
25e4828
Compare
added 5 commits
March 29, 2021 16:21
with equivalent "command -v".
* Replaced all remaining $.. with "$..".
* Replaced raw $? checks with better ||, && and "if" checks.
* Packed chains of 'echo ".." >> $x; echo ".." >> $x' with better
'{ echo ".."; echo ".." } >> $x'.
* exported locally unused variables (that are probably needed by other
scripts).
tuto193
force-pushed
the
lintian_warnings_PL-52
branch
from
25e4828
to
16a9e9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
.sh/.bashscripts so they are nowPOSIXcompliant (used shellcheck to find/fix issues).Why:
How did you test it:
All styling/code changes were tested locally and individually to ensure that functionality remains equal, while making mostly just superficial changes.
Checklist: