Sortable grid part #4 #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows resizing via mouse drag and notifies about difference of movement in pixels since last notification.
This allows to create a copy of the row and only updating specific properties.
Add check if a listener function is passed via props into the new method.
Add a Resizer component underneath each grid Row. It will be possible to reduce the height of a row to currently 50px.
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=========================================
- Coverage 3.5% 3.49% -0.02%
=========================================
Files 651 652 +1
Lines 24299 24383 +84
Branches 5386 5387 +1
=========================================
Hits 852 852
- Misses 20815 20893 +78
- Partials 2632 2638 +6
Continue to review full report at Codecov.
|
swaterkamp
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add resizing of grid rows.