Refactor of CPEs Listpage #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2757 +/- ##
==========================================
+ Coverage 63.37% 63.39% +0.01%
==========================================
Files 1119 1119
Lines 28831 28868 +37
Branches 8148 8154 +6
==========================================
+ Hits 18272 18301 +29
- Misses 9562 9570 +8
Partials 997 997
Continue to review full report at Codecov.
|
bjoernricks
reviewed
Feb 25, 2021
gsa/src/web/pages/cpes/listpage.js
Outdated
| const [, renewSessionTimeout] = useUserSessionTimeout(); | ||
|
|
||
| // Powerfilter | ||
| const fallbackFilter = Filter.fromString('sort-reverse=modified'); |
There was a problem hiding this comment.
Could you do me a favor and move this filter outside of the component function. currently it is re-created on every render which isn't necessary at all.
bjoernricks
suggested changes
Feb 26, 2021
Co-authored-by: Björn Ricks <bjoern.ricks@gmail.com>
bjoernricks
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Why:
How:
Checklist: