Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring CVEs Listpage to use GraphQL #2742

Merged
merged 7 commits into from
Feb 24, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Feb 20, 2021

What:

  • Change CVEs Listpage to use GraphQL
  • Remove withEntitiesContainer of both CVEs list- and detailspage
  • Extend tests

Why:

How:

Checklist:

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #2742 (e3cdad6) into master (62f39fa) will decrease coverage by 0.15%.
The diff coverage is 86.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2742      +/-   ##
==========================================
- Coverage   63.31%   63.15%   -0.16%     
==========================================
  Files        1118     1117       -1     
  Lines       28716    28682      -34     
  Branches     8127     8117      -10     
==========================================
- Hits        18181    18114      -67     
- Misses       9542     9575      +33     
  Partials      993      993              
Impacted Files Coverage Δ
gsa/src/web/pages/cves/detailspage.js 97.67% <ø> (-0.06%) ⬇️
gsa/src/web/pages/cves/filterdialog.js 100.00% <ø> (ø)
gsa/src/web/pages/cves/listpage.js 86.66% <86.04%> (-13.34%) ⬇️
gsa/src/web/pages/cpes/details.js 11.11% <0.00%> (-77.78%) ⬇️
gsa/src/web/pages/cpes/detailspage.js 36.36% <0.00%> (-52.83%) ⬇️
gsa/src/web/components/menu/usermenu.js 77.77% <0.00%> (-7.41%) ⬇️
gsa/src/web/entity/withEntityContainer.js 89.28% <0.00%> (-3.58%) ⬇️
gsa/src/gmp/parser.js 97.77% <0.00%> (-0.17%) ⬇️
gsa/src/gmp/models/cpe.js 100.00% <0.00%> (ø)
gsa/src/web/graphql/cpes.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7ef7c...00af0bc. Read the comment docs.

@y0urself y0urself marked this pull request as ready for review February 23, 2021 20:05
@y0urself y0urself requested a review from a team February 23, 2021 20:05
@y0urself y0urself merged commit f5de3d8 into greenbone:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants