Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement audit component queries #2738

Merged
merged 11 commits into from
Feb 22, 2021

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Feb 19, 2021

What:

  • Converts audit component to no longer use any redux. Load all entities with GraphQL. Auxiliary entities should also be loaded via GraphQL
  • Implement useLazyGetReportFormats, useLazyGetSettings and useGetUsername
  • Implement helper function getSettingValueByName

Why:

How:

Checklist:

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #2738 (d80bd1a) into master (7459154) will increase coverage by 0.01%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2738      +/-   ##
==========================================
+ Coverage   62.95%   62.97%   +0.01%     
==========================================
  Files        1117     1117              
  Lines       28420    28446      +26     
  Branches     8047     8069      +22     
==========================================
+ Hits        17893    17915      +22     
- Misses       9538     9542       +4     
  Partials      989      989              
Impacted Files Coverage Δ
gsa/src/web/pages/audits/component.js 47.97% <64.44%> (-4.32%) ⬇️
gsa/src/gmp/models/setting.js 100.00% <100.00%> (ø)
gsa/src/web/graphql/auth.js 100.00% <100.00%> (ø)
gsa/src/web/graphql/reportformats.js 100.00% <100.00%> (ø)
gsa/src/web/graphql/settings.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7459154...d80bd1a. Read the comment docs.

@saberlynx saberlynx force-pushed the component-queries branch 3 times, most recently from 0287e9e to 25b5086 Compare February 22, 2021 04:44
@saberlynx saberlynx marked this pull request as ready for review February 22, 2021 05:57
@saberlynx saberlynx requested review from a team and bjoernricks February 22, 2021 05:57
@bjoernricks bjoernricks merged commit 1352bda into greenbone:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants