Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for results listpage #2735

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

sarahd93
Copy link
Contributor

What:
Add tests for results listpage.

Why:
The page doesn't have tests yet and we need them before we can start refactoring.

How:

Checklist:

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #2735 (60101c2) into master (fc566a2) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2735      +/-   ##
==========================================
+ Coverage   62.80%   62.90%   +0.09%     
==========================================
  Files        1116     1116              
  Lines       28371    28371              
  Branches     8034     8034              
==========================================
+ Hits        17819    17846      +27     
+ Misses       9563     9537      -26     
+ Partials      989      988       -1     
Impacted Files Coverage Δ
gsa/src/web/pages/results/row.js 82.75% <0.00%> (+10.34%) ⬆️
gsa/src/web/pages/results/table.js 94.73% <0.00%> (+10.52%) ⬆️
gsa/src/web/pages/results/dashboard/cvssdisplay.js 83.33% <0.00%> (+16.66%) ⬆️
...eb/pages/results/dashboard/severityclassdisplay.js 83.33% <0.00%> (+16.66%) ⬆️
gsa/src/web/pages/results/dashboard/loaders.js 88.88% <0.00%> (+22.22%) ⬆️
gsa/src/web/pages/results/dashboard/index.js 100.00% <0.00%> (+25.00%) ⬆️
...rc/web/pages/results/dashboard/wordclouddisplay.js 48.64% <0.00%> (+29.72%) ⬆️
gsa/src/web/pages/results/listpage.js 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc566a2...60101c2. Read the comment docs.

@sarahd93 sarahd93 marked this pull request as ready for review February 17, 2021 14:25
@sarahd93 sarahd93 requested a review from a team February 17, 2021 14:25
@bjoernricks bjoernricks merged commit c32acbe into greenbone:master Feb 17, 2021
@sarahd93 sarahd93 deleted the result_listpage_tests_master branch February 17, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants