Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CVEs detailspage to use GraphQL #2734

Merged
merged 14 commits into from
Feb 19, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Feb 17, 2021

What:

  • Change CVEs detailspage to use GraphQL

Why:

How:

Checklist:

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #2734 (ce34354) into master (c32acbe) will increase coverage by 0.04%.
The diff coverage is 91.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2734      +/-   ##
==========================================
+ Coverage   62.90%   62.94%   +0.04%     
==========================================
  Files        1116     1117       +1     
  Lines       28371    28427      +56     
  Branches     8034     8047      +13     
==========================================
+ Hits        17846    17893      +47     
- Misses       9537     9545       +8     
- Partials      988      989       +1     
Impacted Files Coverage Δ
gsa/src/web/pages/cves/row.js 100.00% <ø> (ø)
gsa/src/gmp/models/cve.js 92.15% <78.57%> (-6.09%) ⬇️
gsa/src/web/graphql/cves.js 84.78% <84.78%> (ø)
gsa/src/web/pages/cves/detailspage.js 97.72% <96.42%> (+4.87%) ⬆️
gsa/src/gmp/parser/cvss.js 100.00% <100.00%> (ø)
gsa/src/web/pages/cves/details.js 100.00% <100.00%> (ø)
gsa/src/web/pages/extras/cvsscalculatorpage.js 91.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32acbe...65694aa. Read the comment docs.

@y0urself y0urself force-pushed the cves-detailspage branch 2 times, most recently from 19c2387 to ab74e7a Compare February 19, 2021 10:47
@y0urself y0urself marked this pull request as ready for review February 19, 2021 11:08
@y0urself y0urself requested a review from a team February 19, 2021 11:08
@y0urself y0urself merged commit aaa495c into greenbone:master Feb 19, 2021
@y0urself y0urself changed the title Cves detailspage Change CVEs detailspage to use GraphQL Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants